benchmark: fix incorrect base64 input in byteLength benchmark #60841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
RafaelGSS
approved these changes
Nov 24, 2025
aduh95
approved these changes
Nov 24, 2025
lpinca
approved these changes
Nov 25, 2025
deokjinkim
approved these changes
Nov 26, 2025
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 470ef98 |
targos
pushed a commit
that referenced
this pull request
Dec 5, 2025
PR-URL: #60841 Fixes: #60836 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 9, 2026
PR-URL: #60841 Fixes: #60836 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 13, 2026
PR-URL: #60841 Fixes: #60836 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 19, 2026
PR-URL: #60841 Fixes: #60836 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmark for
Buffer.byteLengthwithencoding === 'base64'does notreturn a Base64-encoded string.
getInput()discards the encoded value andreturns the original UTF-8 string, causing the benchmark to run against
non-base64 input.
This patch ensures that when
encoding === 'base64', the function returns theactual Base64-encoded string.
This brings the benchmark in line with its expected behavior and makes the
results meaningful.
This fixes the benchmark issue reported in #60836.
Fixes: #60836